Update the primary constructors proposal #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
changed the title
eernstg
force-pushed
the
spec_primary_constructors_may24
branch
from
0eba2aa to
ef2a122
Compare
lrhn
approved these changes
Jun 12, 2024
lrhn
pushed a commit
that referenced
this pull request
Jun 28, 2024
Make adjustments to the proposal about primary constructors such that it is in line with the results from discussions at the recent physical language team meeting. In particular, remove support for a `primary` constructor which is declared in the body of the class/enum/etc, and only allow for the form which is part of the header of the class declaration. Also remove the ability to infer the modifier `required` in a formal parameter declaration. (Inferred `required` is now a separate proposal, see https://github.com/dart-lang/language/blob/main/working/0015-infer-required/feature-specification.md.) The ability to omit `final` from every parameter when the primary constructor is constant is preserved because we already have the ability to omit `final` in the primary constructor of an extension type declaration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes adjustments to the proposal about primary constructors such that it is in line with the results from discussions at the recent physical language team meeting.
In particular, it removes support for a
primaryconstructor which is declared in the body of the class/enum/etc, and only allows for the form which is part of the header of the class declaration. It also removes the ability to infer the modifierrequiredin a formal parameter declaration.(Inferred
requiredis now a separate proposal, see https://github.com/dart-lang/language/blob/main/working/0015-infer-required/feature-specification.md.)It preserves the ability to omit
finalfrom every parameter when the primary constructor is constant, because we already have the ability to omitfinalin the primary constructor of an extension type declaration.