Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wildcard-variables] Allow super._. #3845

Merged
merged 2 commits into from
May 29, 2024
Merged

[wildcard-variables] Allow super._. #3845

merged 2 commits into from
May 29, 2024

Conversation

kallentu
Copy link
Member

Changed the section on super._ to allow it and described a few cases.
Let me know if I got anything wrong or can write something better.

Bob's out, so if either/both of you can take a look, that'd be great!

@kallentu kallentu requested review from lrhn and eernstg May 28, 2024 22:35
Copy link
Member

@lrhn lrhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only style and phrasing nits, and suggestions on the examples.
(Aka: I basically restructured it all, while keeping the message. The message is fine.)

working/wildcards/feature-specification.md Outdated Show resolved Hide resolved
working/wildcards/feature-specification.md Outdated Show resolved Hide resolved
working/wildcards/feature-specification.md Outdated Show resolved Hide resolved
working/wildcards/feature-specification.md Outdated Show resolved Hide resolved
working/wildcards/feature-specification.md Outdated Show resolved Hide resolved
working/wildcards/feature-specification.md Show resolved Hide resolved
@kallentu
Copy link
Member Author

Thanks for the suggestions! I've taken the bulk of what you suggested.

@kallentu kallentu merged commit ae95904 into main May 29, 2024
2 of 3 checks passed
@kallentu kallentu deleted the wc-super branch May 29, 2024 19:54
lrhn pushed a commit that referenced this pull request Jun 28, 2024
* [wildcard-variables] Allow super._.

* Fix comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants