Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify what it means to refer to the augmented member by name in an augmenting member #3874

Merged
merged 2 commits into from
Jun 28, 2024
Merged

clarify what it means to refer to the augmented member by name in an augmenting member #3874

merged 2 commits into from
Jun 28, 2024

Conversation

jakemac53
Copy link
Contributor

Closes #3717

@jakemac53 jakemac53 requested a review from eernstg June 3, 2024 17:34
@davidmorgan davidmorgan mentioned this pull request Jun 27, 2024
Closed
eernstg
eernstg approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eernstg
Copy link
Member

eernstg commented Jun 28, 2024

I must have forgotten this one, sorry about that.

@jakemac53 jakemac53 merged commit 0ee29e7 into main Jun 28, 2024
3 checks passed
@jakemac53 jakemac53 deleted the augmented-name-reference branch June 28, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Denoting members by name in a library augmentation or a library that has augmentations
2 participants
@jakemac53 @eernstg