Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify that types can be omitted from augmenting declarations, and will be inferred from the original #3940

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

jakemac53
Copy link
Contributor

Closes #3879

@davidmorgan
Copy link
Contributor

Thanks! I suggest to tweak the blocks starting "The signature of the constructor augmentation" and "The signature of the function augmentation" at the same time, as the sense of these has now changed: you are not required to repeat everything, it won't necessarily be possible to see the full signature.

@jakemac53
Copy link
Contributor Author

Thanks! I suggest to tweak the blocks starting "The signature of the constructor augmentation" and "The signature of the function augmentation" at the same time, as the sense of these has now changed: you are not required to repeat everything, it won't necessarily be possible to see the full signature.

Updated

@jakemac53 jakemac53 merged commit 73fab25 into main Jun 28, 2024
3 checks passed
@jakemac53 jakemac53 deleted the type-inference branch June 28, 2024 17:23
Copy link
Member

@lrhn lrhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pedantic nits. :)

@davidmorgan
Copy link
Contributor

@jakemac53 oh, now I know why I couldn't comment properly ... GitHub doesn't let you comment on unchanged regions :(

The two regions with "...accomplish anything semantically. But it ensures that anyone reading the..." should probably be removed, they no longer make sense since you can omit information if you want to.

@jakemac53
Copy link
Contributor Author

The two regions with "...accomplish anything semantically. But it ensures that anyone reading the..." should probably be removed, they no longer make sense since you can omit information if you want to.

I left these in, while the types are omitted the parameter names are still required.

jakemac53 added a commit that referenced this pull request Jul 8, 2024
Follow up to some comments on #3940 after it was merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Consider whether to loosen "must match the original" in augmentation spec
3 participants