-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify that types can be omitted from augmenting declarations, and will be inferred from the original #3940
Conversation
…ill be inferred from the original
Thanks! I suggest to tweak the blocks starting "The signature of the constructor augmentation" and "The signature of the function augmentation" at the same time, as the sense of these has now changed: you are not required to repeat everything, it won't necessarily be possible to see the full signature. |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pedantic nits. :)
@jakemac53 oh, now I know why I couldn't comment properly ... GitHub doesn't let you comment on unchanged regions :( The two regions with "...accomplish anything semantically. But it ensures that anyone reading the..." should probably be removed, they no longer make sense since you can omit information if you want to. |
I left these in, while the types are omitted the parameter names are still required. |
Follow up to some comments on #3940 after it was merged
Closes #3879