Change the syntax of augmenting extension type declarations #4016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… does not specify a primary constructor
…, and (2) a complete sentence already
munificent
approved these changes
Aug 6, 2024
jakemac53
reviewed
Aug 6, 2024
jakemac53
approved these changes
Aug 7, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 7, 2024
The PR dart-lang/language#4016 updates the augmentation feature specification such that augmenting extension type declarations do not specify the primary constructor. This CL changes Dart.g (and hence the specification parser) accordingly. It also corrects a typo in Dart.g. Change-Id: I10b49873a96524a9d363f842b39688f3c624b9f5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379100 Reviewed-by: Chloe Stefantsova <[email protected]> Commit-Queue: Erik Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the grammar such that an augmenting extension type declaration does not specify a primary constructor. This means that there is no
constmodifier (which is optional on the introductory declaration, but it is not allowed at all on an augmenting extension type declaration). Also, there is no "parameter list" (known as the<representationSpecification>in the grammar).