Update life of a language feature documentation #4089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't created implementation plan documents for years. We decided that for now, it's better to document the process we're actually following.
This commit adds the following information: - Information about kick-off meetings - How to create implementation tracking issues - How to create a feature flag - How to do language testing - A note to remember to do Google3 testing (details of which will be described in a separate Google-internal document).
kallentu
approved these changes
Sep 10, 2024
| The implementation will be tracked via three artifacts: | ||
|
|
||
| - An implementation plan document | ||
| The implementation will be tracked via two artifacts: | ||
|
|
||
| - A 'implementation' issue. | ||
|
|
||
| - A feature specification document |
There was a problem hiding this comment.
[nit] Could we flip these two bullets to correspond with the other that they get described below?
| - Increment the value of `AnalysisDriver.DATA_VERSION` in | ||
| `pkg/analyzer/lib/src/dart/analysis/driver.dart`. | ||
|
|
||
| - Example CL: https://dart-review.googlesource.com/c/sdk/+/365545 |
There was a problem hiding this comment.
I like the example and the walkthrough. It's useful to have this written down.
doc/life_of_a_language_feature.md
Outdated
| sufficient details to proceed. There may be further iteration on the proposal | ||
| sufficient details to proceed. | ||
|
|
||
| At a minimum, the set of relevant implementation teams should nearly always |
There was a problem hiding this comment.
I really appreciate the explanation behind this. It's the main reason why we want to emphasize kick-off meetings in the first place.
Could we perhaps write the teams in a way that looks more like a checklist/list? I think that'd be useful to look at when you're thinking of the teams you need to talk to.
There was a problem hiding this comment.
Sounds reasonable. Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following information:
It also removes references to implementation plan documents, since we haven't created implementation plan documents for years.