Make adjustments following issue #4015 #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @sgrekhov! If and when this PR is landed, we'd need a couple of tests. |
|
Sure! |
jakemac53
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #4015, it is argued that several system provided members of an enumerated declaration should not be augmentable, namely:
index,hashCode, operator==, andvalues. This PR makes it a compile-time error to augment them.It was also suggested that it should be an error to declare or augment a member of an enum named
name, because this identifier should denote the system provided extension gettername. This PR does not introduce any rules aboutname, because it would be a breaking change to preventenumdeclarations from declaring a member whose name isname(instance or static).Resolves #4015.