Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (apparent) typo in the null-aware-elements example #4107

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

mateusfccp
Copy link
Contributor

It seems in the second example given in the specification, both 'track' and 'genre' should be prefixed with ?, as their initial form are exactly the same as 'title' and 'year', respectively.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mateusfccp
Copy link
Contributor Author

cc @munificent

Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@munificent munificent merged commit 57da765 into dart-lang:main Oct 4, 2024
3 checks passed
@mateusfccp mateusfccp deleted the patch-1 branch October 4, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants