Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.57 update #3

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

bendman
Copy link

@bendman bendman commented Jan 24, 2019

This is largely thanks to work by @vexus2, but I updated the Table of Contents filename extraction to ignore everything before the final slash since some URLs now are absolute and contain subdirectories.

Example of different href attributes handled now:

<li class="navListItem"><a class="navItem" href="inputaccessoryview.html">InputAccessoryView</a></li>
<li class="navListItem"><a class="navItem" href="http://facebook.github.io/react-native/docs/keyboardavoidingview">KeyboardAvoidingView</a></li>

Previously this would return docs as the filename for the second link because it would assume there was a file extension. This new format doesn't assume the filename extension, but removes it if it exists.

@zhigang1992
Copy link

zhigang1992 commented Jan 26, 2019

@bendman thank you so much for the awesome works.

I noticed that Properties tab on the left is not working?

screen shot 2019-01-26 at 1 07 11 pm

Was it always like that?

It was already like that before this update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants