fix!: allowed to make required fields optional #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary disabled due to flakiness. These tests aren't important for now, since we are going to release v1.0.0 with withdrawals disabled.
QuantumExplorer
previously approved these changes
Jul 9, 2024
# Conflicts: # Cargo.lock # packages/platform-test-suite/test/e2e/withdrawals.spec.js
QuantumExplorer
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Data Contract Update allows to make fields optional #1885 which is a good thing but it's not supported currently by DPP and
Drive.
What was done?
How Has This Been Tested?
With tests
Breaking Changes
requiredis not allowed anymore. Consensus rules are changed so previous blockchain data might not be valid.Checklist:
For repository code-owners and collaborators only