Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(drive): skip activation fork if genesis initial core height is set #1977

Open
wants to merge 319 commits into
base: master
Choose a base branch
from

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 17, 2024

Issue being fixed or feature implemented

In case if we want to have precise control on activation height we should use initial_core_chain_locked_height to override default behaviour with activation fork

What was done?

  • Skip fork activation if initial_core_chain_locked_height set in Tenderdash genesis

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

PastaPastaPasta and others added 30 commits March 8, 2024 14:21
…verifier, rs-platform-serialization, rs-platform-serialization-derive, rs-platform-value, rs-sdk, strategy-tests (#1756)
QuantumExplorer and others added 25 commits July 15, 2024 22:10
@shumkov shumkov added this to the v1.0.0 milestone Jul 17, 2024
@shumkov shumkov requested a review from QuantumExplorer as a code owner July 17, 2024 15:27
@shumkov shumkov changed the base branch from v1.0-dev to master August 25, 2024 06:05
@shumkov shumkov requested a review from antouhou as a code owner August 25, 2024 06:05
@thephez thephez removed this from the v1.0.0 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.