Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: reproducible Rust builds #1983

Open
wants to merge 390 commits into
base: master
Choose a base branch
from

Conversation

QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Jul 22, 2024

Issue being fixed or feature implemented

This makes some changes so that we can make reproducible builds.

build process (generally speaking) looks like

docker build -t rust-build-env -f packages/rs-drive-abci/Dockerfile.repro .
docker run --rm -v "$(PWD):/app" -w /app -u "$(shell id -u):$(shell id -g)" \
                rust-build-env \
                cargo build --release --locked

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

lklimek and others added 30 commits April 13, 2024 19:43
lklimek and others added 26 commits July 24, 2024 20:07
incremental = false
rustflags = [
"-C", "relocation-model=pic",
"-C", "strip=debuginfo"
Copy link
Member

@shumkov shumkov Jul 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do
strip = "debuginfo"
for profile

@shumkov shumkov changed the base branch from v1.0-dev to master August 25, 2024 06:05
@shumkov shumkov requested a review from antouhou as a code owner August 25, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.