Remove custom read-csv stuff #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
commented
Dec 16, 2024
| @@ -47,7 +47,7 @@ jobs: | |||
| cache-environment-key: environment-${{ steps.date.outputs.date }}-0 | |||
|
|
|||
| - name: Install current main versions of dask | |||
| run: python -m pip install git+https://github.com/dask/dask | |||
| run: python -m pip install git+https://github.com/phofl/dask@read-csv-legacy | |||
There was a problem hiding this comment.
Suggested change
| run: python -m pip install git+https://github.com/phofl/dask@read-csv-legacy | |
| run: python -m pip install git+https://github.com/dask/dask |
phofl
commented
Dec 16, 2024
| @@ -47,7 +47,7 @@ jobs: | |||
| cache-environment-key: environment-${{ steps.date.outputs.date }}-1 | |||
|
|
|||
| - name: Install current main versions of dask | |||
| run: python -m pip install git+https://github.com/dask/dask | |||
| run: python -m pip install git+https://github.com/phofl/dask@read-csv-legacy | |||
There was a problem hiding this comment.
Suggested change
| run: python -m pip install git+https://github.com/phofl/dask@read-csv-legacy | |
| run: python -m pip install git+https://github.com/dask/dask |
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Dec 17, 2024
Recent changes in dask and dask-expr have broken `dask_cudf.read_csv` (dask/dask-expr#1178, dask/dask#11603). Fortunately, the breaking changes help us avoid legacy CSV code in the long run. Authors: - Richard (Rick) Zamora (https://github.com/rjzamora) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Lawrence Mitchell (https://github.com/wence-) URL: #17612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
together with dask/dask#11603