Build nightlies on tag releases #11014
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 15 files ±0 15 suites ±0 3h 17m 44s ⏱️ +43s Results for commit cb90488. ± Comparison against base commit b663dca. ♻️ This comment has been updated with latest results. |
| github.event_name == 'push' | ||
| && github.ref == 'refs/heads/main' | ||
| && github.repository == 'dask/dask' | ||
| if: github.event_name == 'push' && github.repository == 'dask/dask' |
There was a problem hiding this comment.
Does this condition mean we don't push a new package on tags?
There was a problem hiding this comment.
Checking the docs for push events, it looks like they cover both pushed tags and commits:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push
The main change here is removing the check on github.ref, which would've made it so packages would only get updated on pushed commits, and essentially is just a repetition of the on.push condition we have set:
dask/.github/workflows/conda.yml
Lines 2 to 5 in b663dca
There was a problem hiding this comment.
Okay, sounds good. Thanks for checking
Since Distributed's conda build CI is dependent on
dask-corenightlies for the upcoming release being present, make sure those are always available by also publishing on tag creation (i.e. release).Plays a role in unblocking dask/dask-expr#986, where this issue is present.
pre-commit run --all-files