add deleteDataPipelineEnvironment perm

data-dot-all · Dec 2, 2024 · 6a047e9 · 6a047e9
1 parent 7282bea
commit 6a047e9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/backend/dataall/modules/datapipelines/services/datapipelines_service.py b/backend/dataall/modules/datapipelines/services/datapipelines_service.py
@@ -255,6 +255,7 @@ def _delete_repository(target_uri, accountid, cdk_role_arn, region, repo_name):
 
     @staticmethod
     @TenantPolicyService.has_tenant_permission(MANAGE_PIPELINES)
+    @ResourcePolicyService.has_resource_permission(UPDATE_PIPELINE, param_name='envPipelineUri')
     def delete_pipeline_environment(envPipelineUri: str):
         with _session() as session:
             DatapipelinesRepository.delete_pipeline_environment(session=session, envPipelineUri=envPipelineUri)

diff --git a/tests/test_tenant_unauthorized.py b/tests/test_tenant_unauthorized.py
@@ -449,7 +449,7 @@ def __post_init__(self):
     field_id('Mutation', 'deleteDashboard'): TestData(tenant_perm=MANAGE_DASHBOARDS, resource_perm=DELETE_DASHBOARD),
     field_id('Mutation', 'deleteDataPipeline'): TestData(tenant_perm=MANAGE_PIPELINES, resource_perm=DELETE_PIPELINE),
     field_id('Mutation', 'deleteDataPipelineEnvironment'): TestData(
-        tenant_perm=MANAGE_PIPELINES, resource_ignore=IgnoreReason.NOTREQUIRED
+        tenant_perm=MANAGE_PIPELINES, resource_perm=UPDATE_PIPELINE
     ),
     field_id('Mutation', 'deleteDataset'): TestData(tenant_perm=MANAGE_DATASETS, resource_perm=DELETE_DATASET),
     field_id('Mutation', 'deleteDatasetStorageLocation'): TestData(