Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff formatting #1157

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Ruff formatting #1157

merged 1 commit into from
Apr 9, 2024

Conversation

dlpzx
Copy link
Contributor

@dlpzx dlpzx commented Apr 9, 2024

Feature or Bugfix

  • Bugfix

Detail

In some of the last PRs ruff formatting has not been enforced and there are some formatting errors. This PR is the result of running make lint on the current main branch

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlpzx dlpzx requested a review from SofiaSazonova April 9, 2024 12:55
Copy link
Contributor

@noah-paige noah-paige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dlpzx dlpzx merged commit da194b6 into main Apr 9, 2024
9 checks passed
@petrkalos
Copy link
Contributor

We should check why ruff was not failing in the GH Actions since there were unformatted files

@dlpzx dlpzx deleted the fix/ruff-formatting branch April 25, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants