Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update checkov baseline for cdk synth output #1450

Merged
merged 11 commits into from
Aug 9, 2024
Merged

update checkov baseline for cdk synth output #1450

merged 11 commits into from
Aug 9, 2024

Conversation

noah-paige
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

  • Add checkov scans on cdk synth output

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@noah-paige noah-paige self-assigned this Aug 1, 2024
@noah-paige noah-paige marked this pull request as ready for review August 5, 2024 18:12
@noah-paige noah-paige changed the title update checkov scan cdk synth first update checkov baseline for cdk synth output Aug 5, 2024
@noah-paige noah-paige linked an issue Aug 5, 2024 that may be closed by this pull request
Add cdk synth before running checkov security scans #1023
Closed
petrkalos
petrkalos reviewed Aug 9, 2024
View reviewed changes
tests/modules/mlstudio/cdk/test_sagemaker_studio_stack.py Outdated
Comment on lines 136 to 138
@pytest.mark.skipif(
os.getenv('CHECKOV_ACTIONS', 'false') != 'true', reason='Pytest used for Checkov Scan CDK Synth Output'
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of typing this every time you can define it once in a different file and share it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call out - added skipif decorator to skip_conditions.py file and imported everywhere used now

@noah-paige noah-paige merged commit 49a0a16 into main Aug 9, 2024
9 checks passed
@dlpzx dlpzx deleted the add-checkov-scans-workflow branch September 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrkalos petrkalos petrkalos approved these changes

Assignees

@noah-paige noah-paige

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cdk synth before running checkov security scans
2 participants
@noah-paige @petrkalos