Consistent get_<DATA_ASSET> permissions - Dashboards #1729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpzx
requested review from
noah-paige,
SofiaSazonova and
petrkalos
and removed request for
noah-paige
dlpzx
force-pushed
the
fix/data-assets-perms2
branch
2 times, most recently
from
a0b897c to
31f9aa1
Compare
dlpzx
force-pushed
the
fix/data-assets-perms2
branch
from
31f9aa1 to
aa9100a
Compare
petrkalos
approved these changes
Dec 5, 2024
noah-paige
approved these changes
Dec 5, 2024
| @@ -119,7 +119,7 @@ const DashboardView = () => { | |||
| const fetchItem = useCallback(async () => { | |||
| setLoading(true); | |||
| const response = await client.query(getDashboard(params.uri)); | |||
| if (!response.errors) { | |||
| if (response.data.getDashboard !== null) { | |||
There was a problem hiding this comment.
nit: dispatch all errors if no data
There was a problem hiding this comment.
In the case of Dashboards if there are errors in getting the dashboard (=no data returned), the errors for the restricted information are not very relevant
dlpzx
pushed a commit
that referenced
this pull request
Dec 9, 2024
### Feature or Bugfix - Bugfix ### Detail Before #1729 an unauthorized getDashboard query meant a global failure, after #1729 it returns partial data and only raises an error for `environment` and `restricted` fields. ```json {'data': {'getDashboard': {'SamlGroupName': 'testGroup1', 'created': '2024-12-06 15:27:15.811303', 'dashboardUri': 'obfuscated_uri', 'description': 'No description provided', 'environment': None, 'label': '2024-12-06T14:57:28.249142', 'name': '2024-12-06t14-57-28-249142', 'owner': '[email protected]', 'restricted': None, 'tags': ['2024-12-06T14:57:28.249142'], 'terms': {'count': 0, 'nodes': []}, 'userRoleForDashboard': 'Shared'}}, 'errors': [{'locations': [{'column': 17, 'line': 13}], 'message': '\n' ' An error occurred (UnauthorizedOperation) ' 'when calling GET_DASHBOARD operation:\n' ' User: [email protected] is not ' 'authorized to perform: GET_DASHBOARD on resource: ' 'obfuscated_uri\n' ' ', 'path': ['getDashboard', 'restricted']}, {'locations': [{'column': 17, 'line': 17}], 'message': '\n' ' An error occurred (UnauthorizedOperation) ' 'when calling GET_ENVIRONMENT operation:\n' ' User: [email protected] is not ' 'authorized to perform: GET_ENVIRONMENT on resource: ' 'obfuscated_uri\n' ' ', 'path': ['getDashboard', 'environment']}]} ``` ### Relates Issue introduced at #1729 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
dlpzx
added a commit
that referenced
this pull request
Dec 9, 2024
- Feature - Bugfix This is a continuation of #1727 but for Dashboards. - removes GET_DASHBOARD permission check on get_dashboard - adds a restriction field in the Dashboard type with the restricted information - implement resolver to return the restricted information that checks GET_DASHBOARD permissions. Return defaults for users with no permissions - Adapt frontend to use the restricted fields In addition i made some fixes in the frontend, for example, the default view I changed it to Overview because it improves the experience of a data consumer that is exploring the dashboard metadata. I also removed the forever circular progress in the viewer page if there are errors in the loading of the reader url. - #1727 Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
This is a continuation of #1727 but for Dashboards.
In addition i made some fixes in the frontend, for example, the default view I changed it to Overview because it improves the experience of a data consumer that is exploring the dashboard metadata. I also removed the forever circular progress in the viewer page if there are errors in the loading of the reader url.
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.