Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata form enforcement #1730

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

SofiaSazonova
Copy link
Contributor

@SofiaSazonova SofiaSazonova commented Dec 4, 2024

Feature or Bugfix

  • Feature

Detail

MF view

  1. Enforcement rule tab is added
  2. MF owner can add Enforcement rules, others can view
  3. For each Enforcement rule user can see entities affected by it and if the form is attached or not
  4. Rule is automatically updated for latest MF versions when version is created/deleted

Entity view

  1. If any enforced forms are missing from entity 'Metadata' tab on it's page has "alarm" icon
  2. Missing MFs are highlighted in the list of attached entities

Backend

  1. New core component MetadataFormEntityManager.
  2. All eligible entities register in this manager, when their module is enabled
  3. This manager is unused if metadata form module is not created
  4. Metadata form module depends on DatasetBase module, because we have 'Dataset' enforcement level and logic binded to it.

IMPORTANT
Before this PR is merged, I will deregister modules, which don't have frontend for MF yet.

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)?
    • Is the input sanitized?
    • What precautions are you taking before deserializing the data you consume?
    • Is injection prevented by parametrizing queries?
    • Have you ensured no eval or similar functions are used?
  • Does this PR introduce any functionality or component that requires authorization?
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms?
    • Are you logging failed auth attempts?
  • Are you using or adding any cryptographic features?
    • Do you use a standard proven implementations?
    • Are the used keys controlled by the customer? Where are they stored?
  • Are you introducing any new policies/roles/users?
    • Have you used the least-privilege principle? How?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SofiaSazonova SofiaSazonova changed the title Metadata form enforcement 1 Metadata form enforcement Dec 5, 2024
@SofiaSazonova
Copy link
Contributor Author

Meeting+Recording+-+Sazonova.+Sofia+Instant+Meeting.1.mp4

@SofiaSazonova SofiaSazonova marked this pull request as ready for review December 5, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant