Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Governance Model #736

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Conversation

NickCorbett
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

  • Update to the Governance model to formalise the status of maintainers and how decisions are mode on the project

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.

  • Does this PR introduce or modify any input fields or queries - this includes
    fetching data from storage outside the application (e.g. a database, an S3 bucket)? N/A
    • Is the input sanitized? N/A
    • What precautions are you taking before deserializing the data you consume? N/A
    • Is injection prevented by parametrizing queries? N/A
    • Have you ensured no eval or similar functions are used? N/A
  • Does this PR introduce any functionality or component that requires authorization? N/A
    • How have you ensured it respects the existing AuthN/AuthZ mechanisms? N/A
    • Are you logging failed auth attempts? N/A
  • Are you using or adding any cryptographic features? N/A
    • Do you use a standard proven implementations? N/A
    • Are the used keys controlled by the customer? Where are they stored? N/A
  • Are you introducing any new policies/roles/users? N/A
    • Have you used the least-privilege principle? How? N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
GOVERNANCE.md Outdated
# Project Governance (Very Minimal Governance model)

This open source project is managed by a Steering Committee composed of the maintainers of this project. Maintainers are
defined as individuals with full commit access to the project repositories.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add something to "full commit access" like maintain-level permissions on a repository.

The Steering Committee may, at its discretion, add or remove members who are not maintainers.

## Voting

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are decisions that will be voted? Do we need to discuss everything publicly or can we discuss internally and publish only the final consensus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The committee only votes when it can't reach consensus. So yes, the steering committee can discuss amongst themselves and only go to a public vote if they don't agree.

As the project expands, the steering committee can also agree to set up sub-committees - for example a product management sub-committee to own the roadmap.

* Steering Committee Vote: 3/4 affirmative vote of the Steering Committee to remove a member
* Unreachable Member: If a member is unresponsive for more than six months, the remaining active members of the Steering
Committee may vote to remove the member

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another question: do we specify any rules for ratio of maintainers per affiliation?

Copy link
Contributor

@dlpzx dlpzx Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And , are there any size limitations (max number of maintainers) in the steering committee?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No and no. Once established, the steering committee can vote to add new members, so its in their control.

MAINTAINERS.md Show resolved Hide resolved

### Prioritize Security

Security is your number one priority. Maintainer's Github keys must be password protected securely and any reported security vulnerabilities are addressed before features or bugs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security is "your" number one, to "the" number one priority or "our"

Manage labels, review issues regularly, and triage by labelling them.

We use key value labels, use the `priority:`, `type:` and `status:` when triaging issues.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and recently we added effort:


Ensure the repo highlights features that should be elevated to the project roadmap. Be clear about the feature’s status,
priority, target version, and whether or not it should be elevated to the roadmap. Any feature that you want highlighted
on the OpenSearch Roadmap should be tagged with "roadmap". The OpenSearch [project-meta maintainers](https://github.com/opensearch-project/project-meta/blob/main/MAINTAINERS.md)
Copy link
Contributor

@dlpzx dlpzx Sep 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the OpenSearch roadmap?

with these requirements. If consensus cannot be reached, the Steering Committee will make the decision by a vote.

The Steering Committee Chair will call a vote with reasonable notice to the Steering Committee, setting out a discussion
period and a separate voting period. Any discussion may be conducted in person or electronically by text, voice, or video.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a time frame for discussion/voting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the chair calls for a vote, then the discussion period is set. This is helpful as it puts a deadline on making a decision and avoids "analysis paralysis" The length of time depends on the complexity of the decision being made.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a place where we record decisions? just GitHub issues? can we have like a record of decision issues? or tag them as "decision issues"

Copy link
Contributor

@dlpzx dlpzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for the answers!

@NickCorbett NickCorbett merged commit 6e2fdb0 into data-dot-all:main Oct 12, 2023
8 checks passed
@NickCorbett NickCorbett deleted the governance branch October 12, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants