Core/Organization refactoring #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing:
Local deployment
AWS deployment
|
noah-paige
reviewed
Jan 22, 2024
| return organization | ||
|
|
||
| @staticmethod | ||
| # TODO: resource permission check for permissions.GET_ORGANIZATION ? |
There was a problem hiding this comment.
Let's add this resource permission check for GET_ORGANIZATION
There was a problem hiding this comment.
Let's add this resource permission check for
GET_ORGANIZATION
Tested in AWS Deployment (after addressing TODO comment and adding GET_ORGANIZATION resource permission check of def get_organization(...)
- Create organization
- Modify organization
- Get organization
- List organizations
- Invite group to organization
- List organization groups
- Remove group from organization
- Link environment to organization
- List organization environments
- Archive organization
Think we can add this line then good to approve on my end!
There was a problem hiding this comment.
Thanks a lot for deploying it! I added the permission check
noah-paige
approved these changes
Jan 23, 2024
dlpzx
added a commit
that referenced
this pull request
Feb 8, 2024
…layers (#1044) ### Feature or Bugfix - Refactoring ### Detail Some modules under `core` do not completely follow the standard structure agreed for modules. In this PR I just focus on the module `vpc`: - Add input validation in the `api` layer in the resolvers - Create a `service` layer for `vpc`, where we check permissions and execute business logic - The `db` subpackage should contain all operations on RDS. It should not contain business logic, permissions checks or input validation. ### Relates - #741 - #989 same but for the `vpc` module ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Adding service layer to Organizations in order to follow the resolver-service-repository structure we established for v2.0 modularization.
Also cleanup some dead code.
Relates
#741
Security
Please answer the questions below briefly where applicable, or write
N/A. Based onOWASP 10.
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
evalor similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.