Checkbox #8
Open
Checkbox #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plz, this PR should be merged on |
|
Plus, why this PR has some of my previous commits ? It is weird, isn't it ? |
|
I don't get what exactly is fixed by that PR, can you explain what was wrong before ? |
|
Yes, weird... I can't explain why there are Anne's commits About my commit, correct me if I'm wrong, but the current checkbox component doesn't contain the 'checked' prop. I noticed this when I tried to use it. So I tested it on the playground, and the checkboxes weren't clickable |
|
I found why there were your commits Anne, it's because my PR was to merge on main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, in this PR, you'll find the fix of the checkbox component. There is an add of the "checked" prop, and a small rework of the stories.
Let me know if it's ok. If ok, i'll do the same with the radio component.