fix(structures): Current name can to be in the future /6

dataesr · Dec 18, 2024 · 8731d0a · 8731d0a
1 parent bd55410
commit 8731d0a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/src/api/commons/queries/current-name.query.js b/src/api/commons/queries/current-name.query.js
@@ -41,21 +41,29 @@ export default [
         $reduce: {
           input: '$filteredNames',
           initialValue: null,
-          in: { $cond: [{ $gt: ['$$this.startDate', '$$value.startDate'] }, '$$this', '$$value'] },
+          in: { $cond: [
+            { $ifNull: ['$$this.startDate', 0] },
+            { $cond: [{ $ifNull: ['$$value.startDate', 0] }, {}, '$$value'] },
+            { $cond: [{ $gt: ['$$this.startDate', '$$value.startDate'] }, '$$this', '$$value'] },
+          ] },
         },
       },
     },
   },
   {
     $set: {
       currentName: {
-        $ifNull: ['$currentName', {
-          $reduce: {
-            input: '$filteredNames',
-            initialValue: null,
-            in: { $cond: [{ $gt: ['$$this.createdAt', '$$value.createdAt'] }, '$$this', '$$value'] },
+        $cond: [
+          { $ifNull: ['$currentName.startDate', 0] },
+          '$currentName',
+          {
+            $reduce: {
+              input: '$filteredNames',
+              initialValue: null,
+              in: { $cond: [{ $gt: ['$$this.createdAt', '$$value.createdAt'] }, '$$this', '$$value'] },
+            },
           },
-        }],
+        ],
       },
     },
   },

diff --git a/src/api/structures/__tests__/names.test.js b/src/api/structures/__tests__/names.test.js
@@ -218,7 +218,7 @@ describe('API > structures > names > currentName', () => {
       .expect(201);
   });
 
-  it('returns currentName successfully', async () => {
+  it('returns currentName as last created name', async () => {
     const { body } = await global.superapp
       .get(`/${resource}/${resourceId}`)
       .set('Authorization', authorization)