Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Commit

Permalink
Better Action Next Step when using CLI (#809)
Browse files Browse the repository at this point in the history
* add vhol callout

* remove vs code language

* improve guidance

---------

Co-authored-by: Sung Won Chung <[email protected]>
  • Loading branch information
sungchun12 and Sung Won Chung authored Dec 21, 2023
1 parent bf8c013 commit 1c2350b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ Test SQL code and preview changes by comparing development/staging environment d

**[Get started with data-diff & dbt](https://docs.datafold.com/development_testing/open_source)**

Also available in a [VS Code Extension](https://marketplace.visualstudio.com/items?itemName=Datafold.datafold-vscode)

Reach out on the dbt Slack in [#tools-datafold](https://getdbt.slack.com/archives/C03D25A92UU) for advice and support


Expand Down
12 changes: 8 additions & 4 deletions data_diff/dbt.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import pydantic
import rich
from rich.prompt import Prompt
from rich.markdown import Markdown
from concurrent.futures import ThreadPoolExecutor, as_completed

from data_diff.errors import (
Expand Down Expand Up @@ -50,7 +51,8 @@

logger = getLogger(__name__)
CLOUD_DOC_URL = "https://docs.datafold.com/development_testing/cloud"
EXTENSION_INSTALL_URL = "https://get.datafold.com/datafold-vs-code-install"
DATAFOLD_TRIAL_URL = "https://app.datafold.com/org-signup"
DATAFOLD_INSTRUCTIONS_URL = "https://docs.datafold.com/development_testing/datafold_cloud"


class TDiffVars(pydantic.BaseModel):
Expand Down Expand Up @@ -558,6 +560,8 @@ def _email_signup() -> None:

def _extension_notification() -> None:
if bool_notify_about_extension():
rich.print(
f"\n\nHaving a good time diffing? :heart_eyes-emoji:\nMake sure to check out the free [bold]Datafold VS Code extension[/bold] for more a more seamless diff experience:\n{EXTENSION_INSTALL_URL}"
)
message = "\n\nHaving a good time diffing?\n\nMake sure to check out the free Datafold Cloud Trial for an evolved experience:\n\n- value-level diffs\n- column-level lineage\n"
rich.print(message)
rich.print(Markdown(f"[Sign Up Here]({DATAFOLD_TRIAL_URL})"))
rich.print("")
rich.print(Markdown(f"[Follow the instructions to get started]({DATAFOLD_INSTRUCTIONS_URL})"))

0 comments on commit 1c2350b

Please sign in to comment.