Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine postgres data connector get_schema method #10

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Refine postgres data connector get_schema method #10

merged 2 commits into from
Jul 10, 2024

Conversation

Sevenannn
Copy link
Contributor

@Sevenannn Sevenannn commented Jul 10, 2024 •
edited
Loading

Postgres get_schema would require getting actual data to determine the precision of numeric columns. The current implementation of get_schema would cause numeric columns missing in schema. Therefore refine get_schema method to execute sql query instead of preparing statement

@Sevenannn Sevenannn marked this pull request as ready for review July 10, 2024 04:17
@phillipleblanc phillipleblanc self-requested a review July 10, 2024 04:41
@phillipleblanc phillipleblanc added the bug Something isn't working label Jul 10, 2024
@phillipleblanc phillipleblanc merged commit 8216e56 into datafusion-contrib:main Jul 10, 2024
2 checks passed
@Sevenannn Sevenannn mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

Assignees

@Sevenannn Sevenannn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sevenannn @phillipleblanc