Use random identifier in DuckDB attachment name #205
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a concurrency issue where multiple queries attempting to attach the same DuckDB database would fail with catalog write-write conflicts.
Problem
When multiple queries run concurrently and each tries to attach a database using the same attachment name (e.g., "attachment_0"), they create separate transactions that attempt to modify DuckDB's catalog simultaneously. DuckDB enforces strict serialization of catalog modifications to maintain consistency, causing errors like:
TransactionContext Error: Catalog write-write conflict on create with "attachment_0"
Example of the failing scenario:
Solution
Instead of having concurrent transactions compete to create the same attachment name, we now generate a unique identifier for each attachment. This means each transaction creates its own uniquely named attachment, avoiding catalog conflicts entirely.