Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate schema for SQLite connections #209

Merged
merged 9 commits into from
Dec 30, 2024
Merged

fix: Validate schema for SQLite connections #209

merged 9 commits into from
Dec 30, 2024

Conversation

peasee
Copy link
Collaborator

@peasee peasee commented Dec 30, 2024

🗣 Description

  • Updates schema validation to use a new SchemaValidator trait, wrapping some helpers into common trait functions
  • Updates the schema validation for DuckDB to use the new SchemaValidator pattern
  • Creates a SchemaValidator for SQLite connections

@peasee peasee added the enhancement New feature or request label Dec 30, 2024
@peasee peasee self-assigned this Dec 30, 2024
@phillipleblanc phillipleblanc merged commit 19751e3 into spiceai Dec 30, 2024
2 of 3 checks passed
@phillipleblanc phillipleblanc deleted the fix/sqlite-schema-validation branch December 30, 2024 09:30
@ewgenius ewgenius mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

@sgrebnov sgrebnov Awaiting requested review from sgrebnov

Assignees

@peasee peasee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peasee @phillipleblanc