Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/artifact from dbt cloud #67

Merged
merged 6 commits into from
Jan 6, 2024
Merged

Conversation

datnguye
Copy link
Owner

@datnguye datnguye commented Jan 6, 2024

Partially resolves 63

Description

Add support for dbt Cloud, you're now able to download artifacts from dbt Cloud Admistrative API, instead of compiling locally.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (5ba8122) 100.00% compared to head (ff74344) 95.92%.

Files Patch % Lines
dbterd/adapters/dbt_cloud.py 40.00% 27 Missing ⚠️
dbterd/adapters/base.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #67      +/-   ##
===========================================
- Coverage   100.00%   95.92%   -4.08%     
===========================================
  Files           27       28       +1     
  Lines          653      712      +59     
===========================================
+ Hits           653      683      +30     
- Misses           0       29      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@datnguye datnguye merged commit 51714a4 into main Jan 6, 2024
12 of 14 checks passed
@datnguye datnguye deleted the feat/artifact-from-dbt-cloud branch January 6, 2024 10:52
@ernestoongaro
Copy link

Wow!! This is incredible @datnguye https://dbterd.datnguyen.de/latest/nav/guide/dbt-cloud/download-artifact-from-a-job-run.html so cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants