Reduces noise in golden image tests during failure

davidbyttow · Jan 18, 2021 · 8b1ddb5 · 8b1ddb5
1 parent 98d9500
commit 8b1ddb5
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/vips/image_golden_test.go b/vips/image_golden_test.go
@@ -604,7 +604,8 @@ func assertGoldenMatch(t *testing.T, file string, buf []byte, format ImageType)
 
 	golden, _ := ioutil.ReadFile(goldenFile)
 	if golden != nil {
-		if !assert.Equal(t, golden, buf) {
+		sameAsGolden := assert.True(t, bytes.Equal(buf, golden), "Actual image (size=%d) didn't match expected golden file=%s (size=%d)", len(buf), goldenFile, len(golden))
+		if !sameAsGolden {
 			failed := prefix + "-" + getEnvironment() + ".failed" + ext
 			err := ioutil.WriteFile(failed, buf, 0666)
 			if err != nil {