Fix crash on current sublime #65
Conversation
reloading python 3.3 plugin sublime-rsync-ssh.rsync_ssh
Traceback (most recent call last):
File "/Applications/Sublime Text.app/Contents/MacOS/Lib/python33/sublime_plugin.py", line 308, in reload_plugin
m = importlib.import_module(modulename)
File "./python3.3/importlib/__init__.py", line 90, in import_module
File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 584, in _check_name_wrapper
File "<frozen importlib._bootstrap>", line 1022, in load_module
File "<frozen importlib._bootstrap>", line 1003, in load_module
File "<frozen importlib._bootstrap>", line 560, in module_for_loader_wrapper
File "<frozen importlib._bootstrap>", line 868, in _load_module
File "<frozen importlib._bootstrap>", line 313, in _call_with_frames_removed
File "/Users/ctheune/Library/Application Support/Sublime Text 3/Packages/sublime-rsync-ssh/rsync_ssh.py", line 27, in <module>
def console_show(window=sublime.active_window()):
File "/Applications/Sublime Text.app/Contents/MacOS/Lib/python33/sublime.py", line 515, in active_window
return Window(sublime_api.active_window())
RuntimeError: API is not available
This fixes it.
| if window is None: | ||
| sublime.active_window() |
There was a problem hiding this comment.
This is not correct. It doesn't set window variable.
BTW. This issue will likely be fixed in later ST builds (if it's not already in 4171).
There was a problem hiding this comment.
BTW. The proper fix would be to change the argument to window instead of window=None and just return from this function if window is None.
There was a problem hiding this comment.
Ouch, lol, yeah. Too little coffee today. If that was a ST regression, then I'm happy to forget about this. This was a bit of a panic because my workflow completely broke this morning ... and yeah, it seems like this is in 4171 ...
There was a problem hiding this comment.
I think a proper fix would still be good because it looks like the original code could in some cases trigger a crash (in theory), if it's possible for window to be None. Or maybe the issue in those new builds is that run_command is not available to be used during plugin import so previously it was a noop.
There was a problem hiding this comment.
I'm happy to fix that fix if you like. Using a default argument factory like this isn't quite Pythonic as it has lots of edge cases ...
I've seen the plugin crash today:
This fixes it.