This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Detecting current section fix #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed detecting current section when the nav has a different order than the actual sections and at the bottom of the page (returning the last section regardless of other calcualtions).
|
This fixes my problem! Thanks! |
|
This fixed the same issue for me, too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run into some issues when our top nav was ordered differently than the sections on the page. In our case the link to the top section was moved from the first position to the last which made it always be returned.
This change fixes the issue and makes sure that when you are at the bottom of your page, last section is being returned even if it's to small to be chosen based on regular calculations.