Dockerize application #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we138
reviewed
Apr 29, 2019
.gitignore
Outdated
| @@ -1,3 +1,7 @@ | |||
| /public/assets* | |||
| /tmp | |||
| /coverage | |||
|
|
|||
| .env.development | |||
| !.env.test | |||
There was a problem hiding this comment.
is it typo? do you mean .env.test without !?
There was a problem hiding this comment.
Thx! It is a typo, yeah :-D
we138
reviewed
Apr 29, 2019
gruz0
force-pushed
the
feature/dockerize-app
branch
from
a1a517f to
08b27df
Compare
[11:35] my-projects/rubyjobs.dev ‹feature/dockerize-app›$ docker images | grep ruby
rubyjobsdev_web latest fabd83981577 3 minutes ago 363MB |
.env.development.sample
Outdated
| MODERATION_SESSIONS_SECRET="f62e64af694897dd5a3b949891f2715ada568401017905098809aa80e8943dd0" | ||
| REDISTOGO_URL="redis://localhost:6379" | ||
| HANAMI_ENV=development | ||
| DATABASE_URL=postgres://safelylaunch@postgres/core |
There was a problem hiding this comment.
Suggested change
| DATABASE_URL=postgres://safelylaunch@postgres/core | |
| # For docker development | |
| # DATABASE_URL=postgres://rubyjobs@postgres/core | |
| # for local development | |
| # DATABASE_URL="postgresql://localhost/ruby_jobs_development" |
.env.development.sample
Outdated
| SERVE_STATIC_ASSETS=true | ||
| WEB_SESSIONS_SECRET=238d8ece1579f59647fe3d7c5ca2c78f02142a6392506a929d14c46424e52543 | ||
| MODERATION_SESSIONS_SECRET=f62e64af694897dd5a3b949891f2715ada568401017905098809aa80e8943dd0 | ||
| REDISTOGO_URL=redis://redis:6379 |
There was a problem hiding this comment.
Suggested change
| REDISTOGO_URL=redis://redis:6379 | |
| # For docker development | |
| # REDISTOGO_URL=redis://redis:6379 | |
| # For local development | |
| # REDISTOGO_URL="redis://localhost:6379" |
README.md
Outdated
| @@ -3,32 +3,27 @@ | |||
|
|
|||
| Welcome to your new Hanami project! | |||
|
|
|||
| ## Setup | |||
| ## How to run app inside Docker | |||
There was a problem hiding this comment.
could you move this information to CONTRIBUTING.md file without changing readme?
| postgres: | ||
| image: postgres:9.6.2-alpine | ||
| environment: | ||
| POSTGRES_USER: safelylaunch | ||
| POSTGRES_DB: core | ||
| ports: | ||
| - 5432:5432 | ||
|
|
||
| web: |
There was a problem hiding this comment.
also, we need to add sidekiq too
|
So, will be applied this PR into master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! I dockerized app to use it in development environment 🕺