Review/interview show #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydovanton
requested changes
Jul 30, 2020
| def call(params) | ||
| result = interview_operation.call(company_id: params[:company_id].to_i) | ||
| company_result = operation.call(id: params[:company_id].to_i) | ||
| case result && company_result |
There was a problem hiding this comment.
так нельзя делать, этот код всегда будет company_result пропускать
по идее, ты можешь переписать это вот так:
case company_result
when Success
@company = company_result.value!
@interviews = result.value_or([])
when Failure
redirect_to routes.companies_path
end| @@ -4,7 +4,7 @@ | |||
| change do | |||
| alter_table :companies do | |||
| add_column :interview_rating_total, Float, null: false, default: 0.0 | |||
| add_column :interviews, 'jsonb', default: '{}', null: false | |||
| add_column :interview_ratings, 'jsonb', default: '{}', null: false | |||
There was a problem hiding this comment.
так нельзя делать. нужно делать новую миграцию, в которой будет переименнована колонка
There was a problem hiding this comment.
при этом, зачем тебе тут jsonb поле?
Sim0n-White
force-pushed
the
review/interview_show
branch
from
9344c14 to
80ecead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлено отображение интервью и тесты к ним