Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version combinations in continuous integration #56

Open
yhoiseth opened this issue Mar 19, 2019 · 3 comments
Open

Missing version combinations in continuous integration #56

yhoiseth opened this issue Mar 19, 2019 · 3 comments

Comments

@yhoiseth
Copy link

Thanks a lot for your work on this very useful library.

According to .travis.yml, a lot of version combinations are tested:

env:
    - TOX_ENV=py27-flake8
    - TOX_ENV=py27-docs
    - TOX_ENV=py27-django1.8-drf3.5
    - TOX_ENV=py27-django1.8-drf3.6
    - TOX_ENV=py27-django1.10-drf3.5
    - TOX_ENV=py27-django1.10-drf3.6
    - TOX_ENV=py34-django1.8-drf3.5
    - TOX_ENV=py34-django1.8-drf3.6
    - TOX_ENV=py34-django1.10-drf3.5
    - TOX_ENV=py34-django1.10-drf3.6
    - TOX_ENV=py35-django1.8-drf3.5
    - TOX_ENV=py35-django1.8-drf3.6
    - TOX_ENV=py35-django1.10-drf3.5
    - TOX_ENV=py35-django1.10-drf3.6
    - TOX_ENV=py36-django1.8-drf3.5
    - TOX_ENV=py36-django1.8-drf3.6
    - TOX_ENV=py36-django1.10-drf3.5
    - TOX_ENV=py36-django1.10-drf3.6

However, there are a few (more recent) combinations that are not tested. For example, we're running Python 3.7, Django 2.1 and Django Rest Framework 3.9.

By adding more combinations, we could potentially discover problems that may occur on those.

I'd be happy to contribute by adding more version combinations.

yhoiseth added a commit to yhoiseth/dry-rest-permissions that referenced this issue Mar 20, 2019
I thought I'd start a small attempt at fixing dbkaplan#56.
@yhoiseth
Copy link
Author

What are the versions required by Django and DRF?

Django has the following requirements:

Django version Python versions
1.11 2.7, 3.4, 3.5, 3.6, 3.7 (added in 1.11.17)
2.0 3.4, 3.5, 3.6, 3.7
2.1, 2.2 3.5, 3.6, 3.7

Django Rest Framework (3.9, I assume) requires:

Python (2.7, 3.4, 3.5, 3.6, 3.7)
Django (1.11, 2.0, 2.1, 2.2)

@johnthagen
Copy link

FYI, Python 3.4 is EOL, so you'll notice the latest DRF (3.9 at the moment) doesn't support it.

@johnthagen
Copy link

johnthagen commented Jul 7, 2019

@dbkaplan the last commit in this repository was over 1 year ago. Is this package still maintained? (#60)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants