-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest version combination #57
base: master
Are you sure you want to change the base?
Conversation
I thought I'd start a small attempt at fixing dbkaplan#56.
Hmm… It doesn't seem like an inspection is triggered. Maybe it's because I created a draft request. |
I don't know how valuable DRF 3.7 and 3.8 are to include, so I'm leaving those out for now. |
There are a lot of build jobs now, so I think I'll refrain from adding more unless anyone expresses interest. Cool to see that everything works even on Django 2.2 😀 |
To me, the most important part of this PR is testing with the latest everything: Python 3.7, Django 2.2 (LTS), and DRF 3.9. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest also updating setup.py
classifiers to add Python 3.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be helpful to update the supported versions section of the README as well.
I thought I'd start a small attempt at fixing #56.