Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest version combination #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yhoiseth
Copy link

I thought I'd start a small attempt at fixing #56.

I thought I'd start a small attempt at fixing dbkaplan#56.
@yhoiseth
Copy link
Author

Hmm… It doesn't seem like an inspection is triggered. Maybe it's because I created a draft request.

@yhoiseth yhoiseth marked this pull request as ready for review March 20, 2019 20:34
@yhoiseth
Copy link
Author

I don't know how valuable DRF 3.7 and 3.8 are to include, so I'm leaving those out for now.

@yhoiseth
Copy link
Author

There are a lot of build jobs now, so I think I'll refrain from adding more unless anyone expresses interest. Cool to see that everything works even on Django 2.2 😀

@johnthagen
Copy link

To me, the most important part of this PR is testing with the latest everything: Python 3.7, Django 2.2 (LTS), and DRF 3.9.

Thanks!

Copy link

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest also updating setup.py classifiers to add Python 3.7.

Copy link

@johnthagen johnthagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be helpful to update the supported versions section of the README as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants