Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Json controls and Canvas update #1038

Merged
merged 14 commits into from
Jun 4, 2024

Conversation

thekingofspace
Copy link
Contributor

Added json_read_MOD.js this is useful for the next action

Added json_write_MOD.js this will be useful for data storage purposes, stuff like storing user data for games. Now this could be done using data or file controlling, but this I feel like is nice for readabillity, editing and other uses! With content nesting to it can help with storing other things!

added more shapes to canvas :)

Status

  • Code changes have been tested against the Discord API and the discord.js wrapper, or there are no code changes
  • Documentation has been added/modified, or there is nothing to change (docs/mods.json)

Semantic versioning classification:

  • This PR changes DBM's interface (methods or parameters added to default methods)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link
Contributor

@OneAndOnlyFinbar OneAndOnlyFinbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix checks, then its good

@thekingofspace
Copy link
Contributor Author

I think I got it lint was giving me trouble

@thekingofspace
Copy link
Contributor Author

GOD I am gonna rip my hair out lint will just not work with me

@thekingofspace
Copy link
Contributor Author

on my end the lint is returning any issues try now

Fixed linting issues inside json write

Fixed issue with canvas paint not using cases
@thekingofspace
Copy link
Contributor Author

Solved it, turns out I forgot a few case returns, mb

@OneAndOnlyFinbar OneAndOnlyFinbar merged commit fbcd592 into dbm-network:master Jun 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants