Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_incremental_microbatch to use behavior flag instead of environment variable #1358

Closed
wants to merge 5 commits into from

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Oct 1, 2024

resolves #1359

Problem

dbt-adapters + dbt-core are moving to a behavior flag for gating microbatch functionality. We need to update the tests in dbt-bigquery to reflet this.

Solution

Updated the effected tests to use the new behavior flag defined by dbt-adapters in dbt-labs/dbt-adapters#323

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
@QMalcolm QMalcolm added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
@QMalcolm QMalcolm marked this pull request as ready for review October 1, 2024 21:56
@QMalcolm QMalcolm requested a review from a team as a code owner October 1, 2024 21:56
@QMalcolm QMalcolm removed the Skip Changelog Skips GHA to check for changelog file label Oct 1, 2024
@QMalcolm QMalcolm force-pushed the microbatch-behavior-flag branch from 3cfce54 to 938349a Compare October 21, 2024 22:37
@QMalcolm
Copy link
Contributor Author

QMalcolm commented Nov 9, 2024

Closing, because we're gonna do this differently and these commits would make that messy

@QMalcolm QMalcolm closed this Nov 9, 2024
@mikealfare mikealfare deleted the microbatch-behavior-flag branch November 20, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Microbatch] Update tests to use microbatch behavior flag
2 participants