Converting hologram to drf serializers then generating the open api s… #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a loom link showing what got changed as a part of this update |
GideonShils
reviewed
Sep 28, 2023
There was a problem hiding this comment.
Down to approve once this PR goes through (know you just tagged for viz -> and I'm really just commenting so I can drop it from my gh view haha)
sidpatel13
deleted the
spatel/CC-715-use-dynamically-created-drf-serializers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of converting hologram straight to the open api spec, we convert the serializers to drf serializers and then use those in conjunction with drf spectacular to generate the open api schema. drf spectacular, the package we use to generate the docs tends to understand the drf serializers a lot better.
Checkout the changes using this Loom link