Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CODEOWNERS #28

Merged
merged 5 commits into from
Jan 25, 2024
Merged

Add CODEOWNERS #28

merged 5 commits into from
Jan 25, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 16, 2024 •
edited
Loading

resolves #20

Description

  • Add a CODEOWNERS file. Right now it's just the core team but it may expand. This allows us to require codeowner review before merging PRs to ensure the core team is aware of any changes in dbt-common.
  • Update CI to run with a merge queue. This will eventually be leveraged to test changes against dbt-core before merging. It's not turned on yet though so the workflow changes will change nothing.

Checklist

emmyoop added a commit that referenced this pull request Jan 16, 2024
@emmyoop
remove ard in favor of #28
67b8b89
@emmyoop emmyoop marked this pull request as ready for review January 16, 2024 19:59
@emmyoop emmyoop requested a review from MichelleArk January 16, 2024 19:59
emmyoop added a commit that referenced this pull request Jan 24, 2024
@emmyoop
remove ard in favor of #28
430bd5a
@emmyoop emmyoop merged commit 31804b1 into main Jan 25, 2024
6 checks passed
@emmyoop emmyoop deleted the er/20-branch-protections branch January 25, 2024 15:28
emmyoop added a commit that referenced this pull request Jan 26, 2024
@emmyoop
Implement hatch (#21)
67e25a8 
* commit to hatch

* fix files but it doesnt match pre-commit

* update config

* more reformatting

* fixing mypy

* fixing types

* fix linting, still some pending ignored errors

* fix testing errors

* type fixing, hatch updates

* more hatch setup

* fix test command in ci

* fix test command in ci

* update contributing doc

* remove ard in favor of #28

* move around hatch envs

* fix CI

* Update CONTRIBUTING.md

* fix merge conflict issues

* pre-commit settings

* fix pre-commit

* split up pre-commit linting

* remove extra version declaration

* remove ruff, reorganize

* fux build env

* remove ruff

* move around how env are defined so we can drop into a shell

* dep cleanup

* remove extra line

* review changes

* centralize python/hatch install

* fix action name

* fix step name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@peterallenwebb peterallenwebb peterallenwebb approved these changes

@MichelleArk MichelleArk Awaiting requested review from MichelleArk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up repo rules
3 participants
@emmyoop @peterallenwebb @mikealfare