Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to infer primary key of model #9650

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

aliceliu
Copy link
Contributor

@aliceliu aliceliu commented Feb 23, 2024

resolves #9652

Problem

Solution

Add a method that infers primary key based on constraints and data tests

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

Copy link

cla-bot bot commented Feb 23, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @aliceliu

@aliceliu
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.44%. Comparing base (d1ebf9d) to head (8d06b3a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9650      +/-   ##
==========================================
- Coverage   87.99%   85.44%   -2.55%     
==========================================
  Files         177      177              
  Lines       22315    22350      +35     
==========================================
- Hits        19636    19098     -538     
- Misses       2679     3252     +573     
Flag Coverage Δ
integration 82.72% <2.85%> (-2.87%) ⬇️
unit 62.13% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cla-bot bot commented Feb 23, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @aliceliu

@aliceliu aliceliu force-pushed the 02-23-Add_method_to_infer_primary_key_of_model branch 2 times, most recently from 446cd59 to ec64648 Compare February 23, 2024 19:50
@cla-bot cla-bot bot added cla:yes labels Feb 23, 2024
@aliceliu aliceliu marked this pull request as ready for review February 23, 2024 20:02
@aliceliu aliceliu requested a review from a team as a code owner February 23, 2024 20:02
@aliceliu aliceliu force-pushed the 02-23-Add_method_to_infer_primary_key_of_model branch from ec64648 to 0f79e34 Compare February 23, 2024 23:34
@aliceliu aliceliu force-pushed the 02-23-Add_method_to_infer_primary_key_of_model branch from 0f79e34 to 8d06b3a Compare February 23, 2024 23:50
@MichelleArk MichelleArk merged commit 2b23a03 into main Feb 26, 2024
62 of 72 checks passed
@MichelleArk MichelleArk deleted the 02-23-Add_method_to_infer_primary_key_of_model branch February 26, 2024 04:29
salimmoulouel pushed a commit to salimmoulouel/dbt-core that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement primary key inference for model nodes
2 participants