Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New behavior changes: state_modified_compare_more_unrendered and skip_nodes_if_on_run_start_fails #6204

Merged
merged 22 commits into from
Oct 3, 2024
Merged
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f68f723
on run start behavior change
matthewshaver Oct 1, 2024
66f612f
adding state:modified
matthewshaver Oct 1, 2024
adb5fa2
Adding parameter to table
matthewshaver Oct 1, 2024
316b53b
Merge branch 'current' into hook-change
runleonarun Oct 1, 2024
488e1f5
Merge branch 'current' into hook-change
mirnawong1 Oct 2, 2024
97430a2
Merge branch 'current' into hook-change
runleonarun Oct 2, 2024
0b2f1db
New updates
matthewshaver Oct 2, 2024
257bc4a
Undoing change
matthewshaver Oct 2, 2024
53b4d15
Removing content
matthewshaver Oct 2, 2024
ebe1bb1
Merge branch 'current' into hook-change
matthewshaver Oct 2, 2024
b493b5c
Splitting release note
matthewshaver Oct 2, 2024
1b34dbe
Merge branch 'hook-change' of https://github.com/dbt-labs/docs.getdbt…
matthewshaver Oct 2, 2024
4054384
Moving new content to top
matthewshaver Oct 2, 2024
789e4e5
Update website/docs/docs/dbt-versions/release-notes.md
matthewshaver Oct 2, 2024
44dd028
Removing until `state_modified_compare_vars` is shipped and available
dbeatty10 Oct 3, 2024
3940c63
Update website/docs/reference/global-configs/behavior-changes.md
matthewshaver Oct 3, 2024
5307d86
Merge branch 'current' into hook-change
matthewshaver Oct 3, 2024
b1ad4e0
Keep the `restrict_direct_pg_catalog_access` row as-is
dbeatty10 Oct 3, 2024
2cfa8f2
Update website/docs/reference/global-configs/behavior-changes.md
matthewshaver Oct 3, 2024
027e6d2
Apply suggestions from code review
matthewshaver Oct 3, 2024
b1f29f0
Update website/docs/reference/global-configs/behavior-changes.md
matthewshaver Oct 3, 2024
07c74a6
Update website/docs/reference/global-configs/behavior-changes.md
matthewshaver Oct 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions website/docs/reference/global-configs/behavior-changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ When we use dbt Cloud in the following table, we're referring to accounts that h
| require_resource_names_without_spaces | 2024.05.146 | TBD* | 1.8.0 | 1.9.0 |
| source_freshness_run_project_hooks | 2024.03.61 | TBD* | 1.8.0 | 1.9.0 |
| [Redshift] [restrict_direct_pg_catalog_access](#redshift-restrict_direct_pg_catalog_access) | 2024.09.242 | TBD* | dbt-redshift v1.9.0 | 1.9.0 |
| skip_nodes_if_on_run_start_fails | | TBD* | 1.9.0 | TBD* |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtcohen6 or @graciegoheen, what should be the value for Cloud Intro here?

| state_modified_compare_more_unrendered | | TBD* | 1.9.0 | TBD* |
Copy link
Contributor Author

@matthewshaver matthewshaver Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtcohen6 and @graciegoheen same for the state modified changes


When the dbt Cloud Maturity is "TBD," it means we have not yet determined the exact date when these flags' default values will change. Affected users will see deprecation warnings in the meantime, and they will receive emails providing advance warning ahead of the maturity date. In the meantime, if you are seeing a deprecation warning, you can either:
- Migrate your project to support the new behavior, and then set the flag to `True` to stop seeing the warnings.
Expand Down Expand Up @@ -129,6 +131,20 @@ on-run-start:
```
</File>

### On-run-start hook

The flag is `False` by default.

Set the `skip_nodes_if_on_run_start_fails` flag to `True` to skip all selected resources from running if there is a failure on an `on-run-start` hook.

### Source definitions and variables for state:modified

The flags are `False` by default.

Set `state_modified_compare_more_unrendered` to `True` to start persisting `unrendered_database` and `unrendered_schema` configs during source parsing, and do comparison on unrendered values during `state:modified` checks. Setting the flag to `True` reduces false positives during `state:modified` checks when `prod` and `dev` environments have different configs.

Set the `state_modified_compare_vars` to `True` if a model uses a `var` or `env_var` in its definition. dbt will be able to identify its lineage to include the model in `state:modified` because the `var` or `env_var` value has changed.

## Adapter-specific behavior changes
Some adapters may show behavior changes when certain flags are enabled. Refer to the following sections for each respective adapter.
### [Redshift] restrict_direct_pg_catalog_access
Expand Down
Loading