Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[do not merge] dimensions/measures/entities support meta tag #6633

Merged
merged 17 commits into from
Dec 24, 2024
Merged

[do not merge] dimensions/measures/entities support meta tag #6633

merged 17 commits into from
Dec 24, 2024

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Dec 10, 2024 •
edited by github-actions bot
Loading

@mirnawong1 mirnawong1 requested a review from a team as a code owner December 10, 2024 10:36
@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 24, 2024 10:46am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person labels Dec 10, 2024
@mirnawong1 mirnawong1 changed the title dimensions/measures/entities support meta tag [do not merge] dimensions/measures/entities support meta tag Dec 10, 2024
runleonarun
runleonarun approved these changes Dec 24, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @mirnawong1 My only question is can you configure meta with any metadata? Or are there set values for it? It seems like it can be anything but we don't explicitly say that on the meta page.

@mirnawong1
Copy link
Contributor Author

mirnawong1 commented Dec 24, 2024 •
edited
Loading

This looks great @mirnawong1 My only question is can you configure meta with any metadata? Or are there set values for it? It seems like it can be anything but we don't explicitly say that on the meta page.

hey @mirnawong1 , yes meta includes any custom key-value pair, as long as it's valid yaml. so you can use it for owner, sla, etc anything related to your use case. so i'[ve used favorite_food here and it was visible in th manifest.json file:
Screenshot 2024-12-24 at 10 36 45

@mirnawong1
Copy link
Contributor Author

thanks @runleonarun , added a clarification about the meta acceptance here:

Screenshot 2024-12-24 at 10 42 24

going to merge this now!

@mirnawong1 mirnawong1 enabled auto-merge December 24, 2024 10:43
@mirnawong1 mirnawong1 merged commit a483872 into current Dec 24, 2024
8 checks passed
@mirnawong1 mirnawong1 deleted the add-meta-tag branch December 24, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirnawong1 @runleonarun