Add on_warning to dbtcloud_notification and dbtcloud_partial_notification
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Tweak go.mod to have correct syntax - Run `go mod tidy` - Update to preferred build constraint in tools.go (as of Go 1.18)
- Move guides into templates directory - These are copied as-is by `tfplugindocs` so unnecessary to do in Makefile
Acceptance tests are pending
|
Acceptance Tests pending |
|
Thanks @chasewalden ! At the same time that you add/modify acceptance tests, could you also update the CHANGELOG to mention what was changed? Once done, I can approve it and we can do a new release. |
- Updated test for `dbtcloud_notification` resource - Updated test for `dbtcloud_partial_notification` resource
|
@b-per, Acceptance Tests added and CHANGELOG updated. Not sure if I've done the latter correctly, so please lmk if I missed something. Should be ready to go once CI finishes |
b-per
approved these changes
Jun 10, 2024
|
Thanks @chasewalden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.