[#15] add elasticsearch 8 support, fixes #15, fixes #1

[Morgy93]

The Issue

Elasticsearch 8 does not work currently, because of the failing health check. More info at

• elasticsearch 8 support #15.

See also

• Bump ES to 8.1.1 #1

How This PR Solves The Issue

It adds the ability to use elasticsearch 8
Tested versions:

• 7.17.6
• 7.17.13
• 8.5.3
• 8.10.2

Manual Testing Instructions

Follow the install instructions in the updated README sections.

Automated Testing Overview

The current implementation does not require any change to the current testing.

Related Issue Link(s)

#15

Release/Deployment Notes

Does not affect anything else or has ramifications for other code. Nothing must be done on deployment.

[rfay]

The overall strategy is better to do this stuff with another file that adds the needed changes.

[Morgy93]

The overall strategy is better to do this stuff with another file that adds the needed changes.

You're right, I always forget about that neat feature. Will update accordingly.

[rfay]

Great progress!

[rfay]

Looks great to me, thanks for all the work on this.

[rfay]

Would it be possible to add a test for usage of elasticsearch 8?

[Morgy93]

Would it be possible to add a test for usage of elasticsearch 8?

Yes, definitely. Great idea, will add it to this PR.

[Morgy93]

Added tests for version 8. Updated instructions accordingly.

The install version 8 from release will fail because this feature has not been released, obviously.

[rfay]

More work to go on tests it looks like. Do you know how to run them locally?

[Morgy93]

More work to go on tests it looks like. Do you know how to run them locally?

The "stable" failed at "Download docker images" stage. That's nothing I can control via the bats file.

Error response from daemon: unauthorized: authentication required
Failed to RunSimpleContainer to inspect database version/type: failed to pull image busybox:stable: exit status 1, output=
Error: Process completed with exit code 1.

Can you run it again?

The "HEAD" is working with 3/4 successful tests. The last one is failing as announced:

cp: cannot stat '.ddev/elasticsearch/docker-compose.elasticsearch8.yaml': No such file or directory
Error: Process completed with exit code 1.

That will only work after merge/release.

[Morgy93]

The latest runs are ok:
https://github.com/ddev/ddev-elasticsearch/actions/runs/6725452582/job/18287766401?pr=16

• ok 1 install from directory <- default v7
• ok 2 install from release <- default v7
• ok 3 install version 8 from directory <- good
• not ok 4 install version 8 from release <- expected

https://github.com/ddev/ddev-elasticsearch/actions/runs/6725452582/job/18287766492?pr=16

• ok 1 install from directory <- default v7
• ok 2 install from release <- default v7
• ok 3 install version 8 from directory <- good
• not ok 4 install version 8 from release <- expected

[rfay]

I saw

failed to pull image busybox:stable

and related failures yesterday, probably dockerhub.

I also saw

unauthorized: authentication required

But none of these require auth. But you can docker logout anyway to solve that class of problem.

I restarted both.

[rfay]

You'll have to follow up the

cp: cannot stat '.ddev/elasticsearch/docker-compose.elasticsearch8.yaml': No such file or directory

Did you forget to add it?

[Morgy93]

You'll have to follow up the

cp: cannot stat '.ddev/elasticsearch/docker-compose.elasticsearch8.yaml': No such file or directory

Did you forget to add it?

That only happens during the install version 8 from release test. Because the file needed is available in this PR only. After releasing it will work.
The install version 8 from directory which includes the file works fine. The code is the same except the ddev get location.

[rfay]

Ah, you can disable the release tests until this goes in and then turn them on with a PR after it goes in.

[Morgy93]

Ah, you can disable the release tests until this goes in and then turn them on with a PR after it goes in.

Did not think about that. Interesting approach.
It's committed. Hope tests will run automatically otherwise please rerun.

[rfay]

Ran tests. After you finish this PR you won't have to have tests run for you, it's that github thing of first contribution needing manual intervention.

[rfay]

Yay! Don't forget to follow up with turning on after release.

[rfay]

This is looking good to me, asked for @AronNovak 's review, also fixes his earlier issue. #1

[AronNovak]

👍