Feature/add input validation #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ApiError error = new ApiError(); | ||
| error.code = 500; | ||
| error.status = HttpStatus.INTERNAL_SERVER_ERROR.toString(); | ||
| error.message = "Uh oh! something went wrong processing your request. Please try again or advise the administrator."; | ||
| error.message = exp.getMessage(); |
There was a problem hiding this comment.
I dont think we should show the customer intneral message. The previous approach was better. Also i added some code to log this exception since we are overriding it
| error.status = HttpStatus.BAD_REQUEST.toString(); | ||
| error.message = "Business has already been claimed. Please contact administrator for assistance."; | ||
| error.status = HttpStatus.CONFLICT.toString(); | ||
| error.message = exp.getMessage(); |
There was a problem hiding this comment.
Same comment lets not show user internal message.
| private String businessId; | ||
| @NotNull | ||
| @NotEmpty | ||
| private String email; | ||
| private String phone; |
There was a problem hiding this comment.
Should we validate phone number?
debajyotimahanta
requested changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation for API Input parameters. Please validate the impact to Stripe functionality.