This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Refactor: Make error handling rock solid #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukeocodes
approved these changes
Jun 4, 2024
lukeocodes
added a commit
that referenced
this pull request
Jun 7, 2024
* feat: adding event listeners for relevant events (#8) * feat: adding event listeners for relevant events * feat: adding event listeners for relevant events --------- Co-authored-by: Vaibhav Rai <[email protected]> * Refactor: Make error handling rock solid (#10) * fix: get the thread autoresponding working (#12) * updates sticky message (#11) * updates sticky message * resolves failed lint check * fix: get the thread autoresponding working --------- Co-authored-by: John Vajda (JV) <[email protected]> * fix: suppress errors when fetching sticky (#13) * updates sticky message (#11) * updates sticky message * resolves failed lint check * fix: suppress errors when fetching sticky We don't need to care if the sticky message got deleted some other way. As such, failing to fetch the message should not bubble up and block the process. So we can swallow those errors and proceed with the rest of the logic. --------- Co-authored-by: John Vajda (JV) <[email protected]> --------- Co-authored-by: Vaibhav Rai <[email protected]> Co-authored-by: Naomi <[email protected]> Co-authored-by: John Vajda (JV) <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better error handling with understandable messages.