Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Change some functions in module_deepks into template. #5731

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Refactor: Change some functions in module_deepks into template. #5731

merged 10 commits into from
Dec 16, 2024

Conversation

ErjieWu
Copy link
Collaborator

@ErjieWu ErjieWu commented Dec 13, 2024

What's changed?

  • Change cal_o_delta, cal_e_delta_band and cal_projected_DM into template functions.
  • Temporarily add the function of cal_f_delta_k into cal_f_delta_gamma for future combinations.

@ErjieWu ErjieWu added Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0 labels Dec 13, 2024
@mohanchen mohanchen merged commit 5c815a1 into deepmodeling:develop Dec 16, 2024
14 checks passed
@ErjieWu ErjieWu deleted the refactor branch December 16, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
Refactor Refactor ABACUS codes The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErjieWu @mohanchen