Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor:Remove GlobalC::ucell #5737

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Refactor:Remove GlobalC::ucell #5737

merged 8 commits into from
Dec 18, 2024

Conversation

A-006
Copy link
Collaborator

@A-006 A-006 commented Dec 17, 2024 •
edited
Loading

What's changed?

  • Last PR of remove GlobalC::ucell.
  • Remove all global classes GlobalC::ucell to increase program safety and address previously unresolved problemes.
  • The Ucell had an uninitialized bug. Thanks to @Qianruipku for fixing the problem. Moving forward, I will set the UnitUcell in the atomic_world function, not in the drive_run function, to avoid initializing a risky ucell for the entire program.

@A-006 A-006 marked this pull request as draft December 17, 2024 03:02
@A-006 A-006 marked this pull request as ready for review December 18, 2024 09:22
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Dec 18, 2024
@mohanchen
Copy link
Collaborator

Great job! Thanks!

@mohanchen mohanchen merged commit c611100 into deepmodeling:develop Dec 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@A-006 @mohanchen