Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove the Psi Constructors using int* ngk_in #5745

Merged
merged 12 commits into from
Dec 24, 2024
Merged

Refactor: remove the Psi Constructors using int* ngk_in #5745

merged 12 commits into from
Dec 24, 2024

Conversation

haozhihan
Copy link
Collaborator

No description provided.

@haozhihan haozhihan changed the title Refactor: delete Psi(const int* ngk_in) from module_psi not ready Dec 20, 2024
@haozhihan haozhihan changed the title not ready Refactor: remove the Psi Constructors using int* ngk_in Dec 22, 2024
@haozhihan haozhihan marked this pull request as ready for review December 22, 2024 13:21
@haozhihan haozhihan requested a review from mohanchen December 23, 2024 05:58
@haozhihan
Copy link
Collaborator Author

#5754

@haozhihan
Copy link
Collaborator Author

haozhihan commented Dec 24, 2024 •
edited
Loading

This PR is the first step of using vector to replace int *ngk in psi class.

Since directly replacing all int * ngk will bring many unpredictable bugs, we can only replace them one by one and check the correctness of the program at the same time.

So, first sort out, summarize and replace all constructors that use int *ngk in psi class in this PR.

@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Dec 24, 2024
@mohanchen mohanchen merged commit 91b0281 into deepmodeling:develop Dec 24, 2024
14 checks passed
@haozhihan haozhihan deleted the psi-ngk branch December 25, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haozhihan @mohanchen