Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade support to TF 2.10 #901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade support to TF 2.10 #901

wants to merge 1 commit into from

Conversation

marcan
Copy link

@marcan marcan commented Jun 21, 2024

Upgrade to TF 2.10

  • I read contributing guideline
  • I didn't find a similar pull request already open.
  • My PR is related to Spleeter only, not a derivative product (such as Webapplication, or GUI provided by others)

Description

This is the oldest version with arm64 builds, enabling spleeter to work on arm64 Linux. We need to pin numpy to <2.0 to avoid incompatibilities, but we also need new enough versions for the TF 2.10 builds to work. This in turn requires dropping Python 3.7 support (which is very old at this point).

This also upgrades mypy to 0.991 since the old version runs into a broken version of the typed-ast dependency on Python 3.10.

How this patch was tested

Tested on an ARM64 M1 Pro MacBook Pro running Fedora Asahi Remix in a Python3.10 venv, running the tests with poetry run pytest tests/ as well as a simple usage test of spleeter.

  • I implemented unit test whicn ran successfully using poetry run pytest tests/
  • Code has been formatted using poetry run black spleeter
  • Imports has been formatted using `poetry run isort spleeter``

This is the oldest version with arm64 builds, enabling spleeter to work
on arm64 Linux. We need to pin numpy to <2.0 to avoid incompatibilities,
and also drop Python 3.7 support to make sure we get new enough
versions of numpy and scipy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant